----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16643/#review31225 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java <https://reviews.apache.org/r/16643/#comment59622> I think we should skip the "role name:" in the output, similar to the change you made in different jira for 'show role grant' ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java <https://reviews.apache.org/r/16643/#comment59623> this cast should not be needed. Not sure why it came to be used in other places in this class. ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g <https://reviews.apache.org/r/16643/#comment59624> It should be "show roles" instead of "show role grants" - Thejas Nair On Jan. 6, 2014, 1:11 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16643/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2014, 1:11 a.m.) > > > Review request for hive. > > > Bugs: HIVE-5941 > https://issues.apache.org/jira/browse/HIVE-5941 > > > Repository: hive-git > > > Description > ------- > > SHOW ALL ROLES - This will list all > currently existing roles. This will be available only to the superuser. > This task includes parser changes. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 328c14b > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 8bd0927 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g da745d7 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 5dff3fe > ql/src/java/org/apache/hadoop/hive/ql/parse/IdentifiersParser.g 9b6fc3b > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java > 542d59a > ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java bfd6b77 > ql/src/java/org/apache/hadoop/hive/ql/plan/RoleDDLDesc.java 99dadb0 > ql/src/test/queries/clientpositive/show_roles.q PRE-CREATION > ql/src/test/results/clientpositive/show_roles.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/16643/diff/ > > > Testing > ------- > > > Thanks, > > Navis Ryu > >
