----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16328/#review30725 -----------------------------------------------------------
Ship it! LGTM - Prasad Mujumdar On Dec. 17, 2013, 9:23 p.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16328/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2013, 9:23 p.m.) > > > Review request for hive and Prasad Mujumdar. > > > Bugs: HIVE-5992 > https://issues.apache.org/jira/browse/HIVE-5992 > > > Repository: hive-git > > > Description > ------- > > The fix is to make the two UDAFs report convert timestamp to double in terms > of seconds and the fraction of the second. > Test is added to cover the case. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java > 41d5efd > ql/src/test/queries/clientpositive/timestamp_3.q e5a4345 > ql/src/test/results/clientpositive/timestamp_3.q.out 8544307 > > Diff: https://reviews.apache.org/r/16328/diff/ > > > Testing > ------- > > Unit test. New unit test. Regression suite. > > > Thanks, > > Xuefu Zhang > >
