-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16330/
-----------------------------------------------------------
(Updated Dec. 19, 2013, 7:57 p.m.)
Review request for hive.
Changes
-------
Moved the TestBeeLineWithArgs under /itests where it is run. Added a unit test
"testBeelineMultiHiveVariable" for the case of multiple hivevars.
Bugs: HIVE-6045
https://issues.apache.org/jira/browse/HIVE-6045
Repository: hive-git
Description
-------
The implementation appends hivevars to the jdbc url in the form
"var1=val1&var2=val2$var3-val3"
but the regex used to parse this is expecting the delimiter to be ";". Changed
the regex to fit the hivevar format.
Diffs (updated)
-----
beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java 1de5829
beeline/src/test/org/apache/hive/beeline/src/test/TestBeeLineWithArgs.java
819a28d
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
PRE-CREATION
Diff: https://reviews.apache.org/r/16330/diff/
Testing
-------
Looks like TestBeelineWithArgs is no longer being run, and there are a lot of
failures there due to other changes even without this change. Probably we need
to move that test, and see if we can add a unit test there for this case.
Thanks,
Szehon Ho
