----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16184/#review30523 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java <https://reviews.apache.org/r/16184/#comment58465> skipHeader and initiaizeFooterBuf can be moved to a common util class and shared. We just need to pass the member variables as additional params ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java <https://reviews.apache.org/r/16184/#comment58463> code such as this block for parsing header count can be moved to a util class and shared between the two places ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java <https://reviews.apache.org/r/16184/#comment58464> code such as this block for parsing header count can be moved to a util class and shared between the two places ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java <https://reviews.apache.org/r/16184/#comment58466> logic of this block also looks same in 2 places, can we move it to a common util function ? - Thejas Nair On Dec. 11, 2013, 9:19 p.m., Shuaishuai Nie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16184/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2013, 9:19 p.m.) > > > Review request for hive, Eric Hanson and Thejas Nair. > > > Bugs: hive-5795 > https://issues.apache.org/jira/browse/hive-5795 > > > Repository: hive-git > > > Description > ------- > > Hive should be able to skip header and footer rows when reading data file for > a table > (follow up with review https://reviews.apache.org/r/15663/diff/#index_header) > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java fa3e048 > conf/hive-default.xml.template c61a0bb > data/files/header_footer_table_1/0001.txt PRE-CREATION > data/files/header_footer_table_1/0002.txt PRE-CREATION > data/files/header_footer_table_1/0003.txt PRE-CREATION > data/files/header_footer_table_2/2012/01/01/0001.txt PRE-CREATION > data/files/header_footer_table_2/2012/01/02/0002.txt PRE-CREATION > data/files/header_footer_table_2/2012/01/03/0003.txt PRE-CREATION > itests/qtest/pom.xml c3cbb89 > ql/src/java/org/apache/hadoop/hive/ql/exec/FetchOperator.java d2b2526 > ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java > dd5cb6b > ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 974a5d6 > > ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveBinarySearchRecordReader.java > 85dd975 > ql/src/test/org/apache/hadoop/hive/ql/io/TestSymlinkTextInputFormat.java > 0686d9b > ql/src/test/queries/clientnegative/file_with_header_footer_negative.q > PRE-CREATION > ql/src/test/queries/clientpositive/file_with_header_footer.q PRE-CREATION > ql/src/test/results/clientnegative/file_with_header_footer_negative.q.out > PRE-CREATION > ql/src/test/results/clientpositive/file_with_header_footer.q.out > PRE-CREATION > serde/if/serde.thrift 2ceb572 > > serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java > 22a6168 > > Diff: https://reviews.apache.org/r/16184/diff/ > > > Testing > ------- > > > Thanks, > > Shuaishuai Nie > >
