[
https://issues.apache.org/jira/browse/HIVE-5414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849706#comment-13849706
]
Phabricator commented on HIVE-5414:
-----------------------------------
thejas has commented on the revision "HIVE-5414 [jira] The result of show grant
is not visible via JDBC".
The patch does not apply on trunk anymore. Can you also please rebase ?
Sorry about the delay in reviewing this patch.
INLINE COMMENTS
ql/src/java/org/apache/hadoop/hive/ql/plan/ShowGrantDesc.java:36 I think
"property" would be a better name for column, than "key".
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java:1816
can you also add test for column name and column type of result ?
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java:1814
can you also add a test for 'show roles' ?
REVISION DETAIL
https://reviews.facebook.net/D13209
To: JIRA, navis
Cc: Unknown Object (Phabricator User), thejas
> The result of show grant is not visible via JDBC
> ------------------------------------------------
>
> Key: HIVE-5414
> URL: https://issues.apache.org/jira/browse/HIVE-5414
> Project: Hive
> Issue Type: Bug
> Components: Authorization, JDBC
> Reporter: Navis
> Assignee: Navis
> Priority: Trivial
> Attachments: D13209.1.patch, D13209.2.patch, D13209.3.patch,
> HIVE-5414.4.patch.txt
>
>
> Currently, show grant / show role grant does not make fetch task, which
> provides the result schema for jdbc clients.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
