----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16076/#review30434 -----------------------------------------------------------
service/if/TCLIService.thrift <https://reviews.apache.org/r/16076/#comment58226> Need to add HIVE_CLI_SERVICE_PROTOCOL_V5 and update existing references to HIVE_CLI_SERVICE_PROTOCOL_V5. service/if/TCLIService.thrift <https://reviews.apache.org/r/16076/#comment58229> Please add TBoolColumn, TByteColumn, etc instead of redefining the existing T*Value structs. service/if/TCLIService.thrift <https://reviews.apache.org/r/16076/#comment58228> These changes break compatibility with older HiveServer2 clients. Instead I think we want to make it possible for a client to pick between the existing serialization format and the new column-oriented serialization format by setting a new optional field in TFetchResultsReq. service/if/TCLIService.thrift <https://reviews.apache.org/r/16076/#comment58230> We aren't using TColumn right now so it should be ok to redefine the contents of this struct. Also, it may be worth trying to save a bit of space by moving the "binary nulls" field outside of the union of the individual T*Column structs, e.g: union TColumn { 1: TBoolColumn boolColumn ... 7: TStringColumn stringColumn } struct TNullableColumn { 1: TColumn column 2: binary nulls } service/if/TCLIService.thrift <https://reviews.apache.org/r/16076/#comment58233> Please add a new struct TColumnSet instead of modifying TRowSet. service/if/TCLIService.thrift <https://reviews.apache.org/r/16076/#comment58232> please add: 4: optional TResultSetType tResultSetType where TResultSetType is an enum that defaults to ROW_ORIENTED_RESULTSET service/if/TCLIService.thrift <https://reviews.apache.org/r/16076/#comment58231> please add: 4: optional TColumnSet columnResults - Carl Steinbach On Dec. 16, 2013, 2:04 a.m., Navis Ryu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16076/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2013, 2:04 a.m.) > > > Review request for hive. > > > Bugs: HIVE-3746 > https://issues.apache.org/jira/browse/HIVE-3746 > > > Repository: hive-git > > > Description > ------- > > serialize result set in columnar format > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/miniHS2/TestHiveServer2.java > eb08628 > jdbc/src/java/org/apache/hive/jdbc/HiveBaseResultSet.java b02f374 > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 061337d > service/if/TCLIService.thrift 62a9730 > service/src/gen/thrift/gen-cpp/TCLIService_types.h 853bb4c > service/src/gen/thrift/gen-cpp/TCLIService_types.cpp 7ab1310 > > service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/ThriftHive.java > 1c44789 > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TBinaryValue.java > PRE-CREATION > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TBoolValue.java > c7495ee > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TByteValue.java > 23d9693 > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TColumn.java > 497cc01 > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TColumnValue.java > 44da2cd > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TDoubleValue.java > d215736 > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TExecuteStatementReq.java > ea656ac > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTablesReq.java > 1cb5147 > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TI16Value.java > bb5ae96 > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TI32Value.java > 059408b > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TI64Value.java > 9a941cc > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionReq.java > 8ab8297 > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionResp.java > 688f790 > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRow.java > 0b6772c > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRowSet.java > db2262d > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TStatus.java > 81c2f16 > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TStringValue.java > af7a109 > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTableSchema.java > ff5e54d > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTypeDesc.java > 251f86a > > service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTypeQualifiers.java > 3935555 > service/src/gen/thrift/gen-py/TCLIService/ttypes.py 185ea5b > service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb c94acbf > service/src/java/org/apache/hive/service/cli/ColumnValue.java cf2b3d9 > service/src/java/org/apache/hive/service/cli/Row.java 9e419e9 > service/src/java/org/apache/hive/service/cli/RowSet.java dce506d > service/src/java/org/apache/hive/service/cli/TableSchema.java 155f529 > > service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java > 70cabe3 > > service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java > 8d09d1c > > service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java > e3b161a > > service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java > f413116 > > service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java > d168d5e > > service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java > c8cce08 > > service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java > a923199 > > service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java > e5bfd92 > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > 296f8b3 > > Diff: https://reviews.apache.org/r/16076/diff/ > > > Testing > ------- > > > Thanks, > > Navis Ryu > >
