> On Dec. 6, 2013, 8:04 p.m., Thejas Nair wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java, > > line 1833 > > <https://reviews.apache.org/r/16063/diff/2/?file=394957#file394957line1833> > > > > comment not applicable ?
ah, CPT errors. Removed. > On Dec. 6, 2013, 8:04 p.m., Thejas Nair wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java, > > line 1837 > > <https://reviews.apache.org/r/16063/diff/2/?file=394957#file394957line1837> > > > > why not re-use execFetchFirst here ? execFetchFirst was more tightly associated with the SQL query. Changed it to be more generic and used in the other tests as well. > On Dec. 6, 2013, 8:04 p.m., Thejas Nair wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java, > > line 1856 > > <https://reviews.apache.org/r/16063/diff/2/?file=394957#file394957line1856> > > > > comment not applicable ? removed > On Dec. 6, 2013, 8:04 p.m., Thejas Nair wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java, > > line 1884 > > <https://reviews.apache.org/r/16063/diff/2/?file=394957#file394957line1884> > > > > you can use fail("..") instead of assertTrue here. Done > On Dec. 6, 2013, 8:04 p.m., Thejas Nair wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java, > > line 1886 > > <https://reviews.apache.org/r/16063/diff/2/?file=394957#file394957line1886> > > > > I think the error message would need to be updated in the test case. yes, Thanks for catching that. It looks like the hive-unit tests is getting skipped all together due to some other build changes. Hence I didn't notice the failures. Added SQLState in the error and updated the test to check for SQLState instead of messages. > On Dec. 6, 2013, 8:04 p.m., Thejas Nair wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java, > > line 1913 > > <https://reviews.apache.org/r/16063/diff/2/?file=394957#file394957line1913> > > > > nit - a trailing white space Removed > On Dec. 6, 2013, 8:04 p.m., Thejas Nair wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java, > > line 1918 > > <https://reviews.apache.org/r/16063/diff/2/?file=394957#file394957line1918> > > > > Thanks for these comments! > > can you extend the comment to - "@param oneRowOnly - read only one row > > from result" > > Done - Prasad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16063/#review29900 ----------------------------------------------------------- On Dec. 6, 2013, 5:37 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16063/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2013, 5:37 a.m.) > > > Review request for hive, Brock Noland and Thejas Nair. > > > Bugs: HIVE-4395 > https://issues.apache.org/jira/browse/HIVE-4395 > > > Repository: hive-git > > > Description > ------- > > Support fetch-from-start for hiveserver2 fetch operations. > - Handle new fetch orientation for various HS2 operations. > - Added support to reset the read position in Hive driver > - Enabled scroll cursors with support for positioning cursor to start of > resultset > > > Diffs > ----- > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > 7b1c9da > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java ef39573 > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 812ee56 > jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java fce19bf > ql/src/java/org/apache/hadoop/hive/ql/Context.java ed502a7 > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 86db406 > ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 343f760 > ql/src/java/org/apache/hadoop/hive/ql/processors/DfsProcessor.java ce54e0c > > service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java > 581e69c > > service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java > af87a90 > > service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java > 0fe01c0 > > service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java > bafe40c > > service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java > 2be018e > > service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java > 7e8a06b > > service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java > 2daa9cd > > service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java > a1ac55b > service/src/java/org/apache/hive/service/cli/operation/Operation.java > 6f4b8dc > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > 301187d > > Diff: https://reviews.apache.org/r/16063/diff/ > > > Testing > ------- > > Added new testcases to TestJdbcDriver2 > > > Thanks, > > Prasad Mujumdar > >
