[ https://issues.apache.org/jira/browse/HIVE-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830778#comment-13830778 ]
Hive QA commented on HIVE-5763: ------------------------------- {color:green}Overall{color}: +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12615470/HIVE-5763.2.patch {color:green}SUCCESS:{color} +1 4684 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/421/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/421/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12615470 > ExprNodeGenericFuncDesc.toString() generating unbalanced parenthesises > ---------------------------------------------------------------------- > > Key: HIVE-5763 > URL: https://issues.apache.org/jira/browse/HIVE-5763 > Project: Hive > Issue Type: Bug > Components: Query Processor > Affects Versions: 0.12.0 > Reporter: Xuefu Zhang > Assignee: Xuefu Zhang > Priority: Minor > Attachments: HIVE-5763.1.patch, HIVE-5763.2.patch, HIVE-5763.patch > > > This makes the generated expression tree unreadable. > {code} > public String toString() { > StringBuilder sb = new StringBuilder(); > sb.append(genericUDF.getClass().toString()); > sb.append("("); > for (int i = 0; i < chidren.size(); i++) { > if (i > 0) { > sb.append(", "); > } > sb.append(chidren.get(i).toString()); > } > sb.append("("); -- This needs to be removed. > sb.append(")"); > return sb.toString(); > } > {code} -- This message was sent by Atlassian JIRA (v6.1#6144)