----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15804/#review29332 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java <https://reviews.apache.org/r/15804/#comment56518> I don't think I get you. Could you give an example about how implementation here is different from sql server's? The decimal part of a decimal number is as important as the integer part in applications where decimal type is required. Otherwise, double might be better. Thus, a decimal number of a certain decimal type needs to comply with the type's precision/scale. I don't think we should store number 456.78 to a type decimal(6,4), about which we already concluded the discussion. - Xuefu Zhang On Nov. 22, 2013, 9:42 p.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15804/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2013, 9:42 p.m.) > > > Review request for hive. > > > Bugs: HIVE-5866 > https://issues.apache.org/jira/browse/HIVE-5866 > > > Repository: hive-git > > > Description > ------- > > Fixed the problem. Added a unit test. Corrected the output of a few q tests. > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java > a1015e9 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java > 0b902e9 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java > 538c07e > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java > 472e1dd > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java > 2e8d364 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java > 35f639e > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java > 6b18303 > > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java > 581c1a8 > ql/src/test/results/clientpositive/decimal_precision.q.out 2ee3578 > ql/src/test/results/clientpositive/decimal_udf.q.out ed5bc65 > ql/src/test/results/clientpositive/ql_rewrite_gbtoidx.q.out 83787ee > ql/src/test/results/clientpositive/vectorization_5.q.out 54aad90 > ql/src/test/results/clientpositive/vectorization_short_regress.q.out > c9296e1 > > Diff: https://reviews.apache.org/r/15804/diff/ > > > Testing > ------- > > > Thanks, > > Xuefu Zhang > >
