[
https://issues.apache.org/jira/browse/HIVE-5817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13829536#comment-13829536
]
Eric Hanson commented on HIVE-5817:
-----------------------------------
I'm looking at HIVE-5817.00-broken.patch. It looks like a reasonable approach.
It does complicate the function interfaces in VectorizationContext a bit
because the soureId parameter is added to a lot of functions. The way I
understand it, Remus suggested maybe having a different VectorizationContext
for each operator (for which there would be a specific VectorizedRowBatch
structure). Then the sourceId could perhaps be an instance variable of
VectorizationContext and make the function interface simpler. Does anybody have
an opinion on this?
> column name to index mapping in VectorizationContext is broken
> --------------------------------------------------------------
>
> Key: HIVE-5817
> URL: https://issues.apache.org/jira/browse/HIVE-5817
> Project: Hive
> Issue Type: Bug
> Components: Vectorization
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Critical
> Attachments: HIVE-5817-uniquecols.broken.patch,
> HIVE-5817.00-broken.patch
>
>
> Columns coming from different operators may have the same internal names
> ("_colNN"). There exists a query in the form {{select b.cb, a.ca from a JOIN
> b ON ... JOIN x ON ...;}} (distilled from a more complex query), which runs
> ok w/o vectorization. With vectorization, it will run ok for most ca, but for
> some ca it will fail (or can probably return incorrect results). That is
> because when building column-to-VRG-index map in VectorizationContext,
> internal column name for ca that the first map join operator adds to the
> mapping may be the same as internal name for cb that the 2nd one tries to
> add. 2nd VMJ doesn't add it (see code in ctor), and when it's time for it to
> output stuff, it retrieves wrong index from the map by name, and then wrong
> vector from VRG.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
