----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15755/#review29221 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddDate.java <https://reviews.apache.org/r/15755/#comment56358> Why these variables are transient? ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddDate.java <https://reviews.apache.org/r/15755/#comment56359> Will unit be null? I think we'd better using this form: "YEAR".equalsIgnoreCase(unit) - jin jie On Nov. 21, 2013, 8:13 a.m., Anandha L Ranganahan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15755/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2013, 8:13 a.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: https://issues.apache.org/jira/browse/HIVE-5810 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/HIVE-5810 > > > Repository: hive-git > > > Description > ------- > > The function add_date(date,unit,expr) and returns the value. > > For example, > add_date('2013-11-09','DAY',2) will return 2013-11-11. > add_date('2013-11-09','Month',2) will return 2014-01-09. > add_date('2013-11-09','Year',2) will return 2014-11-11. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 5eb321c > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddDate.java > e69de29 > ql/src/test/queries/clientpositive/date_udf.q c55b9f9 > ql/src/test/results/clientpositive/date_udf.q.out 28e4f08 > > Diff: https://reviews.apache.org/r/15755/diff/ > > > Testing > ------- > > Testing complted and attached result. > > > Thanks, > > Anandha L Ranganahan > >
