----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15649/#review29087 -----------------------------------------------------------
+1 (with minor comments) hcatalog/bin/hcat <https://reviews.apache.org/r/15649/#comment56209> Same as above: Create a new variable and use it. hcatalog/bin/hcat.py <https://reviews.apache.org/r/15649/#comment56208> If possible, creating a variable and use the variable would make it much better.| - Mohammad Islam On Nov. 18, 2013, 4:49 p.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15649/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2013, 4:49 p.m.) > > > Review request for hive. > > > Bugs: HIVE-5842 > https://issues.apache.org/jira/browse/HIVE-5842 > > > Repository: hive-git > > > Description > ------- > > Fixes path issues with hcatalog in maven tarball post mavenization. > > Also removes a comical amount of trailing whitespace in hcat scripts. > > > Diffs > ----- > > hcatalog/bin/hcat b4d4226 > hcatalog/bin/hcat.py 53fc387 > hcatalog/bin/hcat_server.py 51a11e6 > hcatalog/bin/hcat_server.sh bf3c3f1 > hcatalog/bin/hcatcfg.py 47a56d8 > hcatalog/webhcat/svr/src/main/bin/webhcat_config.sh 6b0b578 > hcatalog/webhcat/svr/src/main/bin/webhcat_server.sh 600c16d > > Diff: https://reviews.apache.org/r/15649/diff/ > > > Testing > ------- > > Tested hcat scripts manually > > > Thanks, > > Brock Noland > >
