[ 
https://issues.apache.org/jira/browse/HIVE-5626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817477#comment-13817477
 ] 

Ashutosh Chauhan commented on HIVE-5626:
----------------------------------------

Patch looks good. Thanks for refactoring. How did you test this one, by looking 
at logs ? Is it possible to add junit tests for this as we have added for 
direct-sql for other cases?

> enable metastore direct SQL for drop/similar queries
> ----------------------------------------------------
>
>                 Key: HIVE-5626
>                 URL: https://issues.apache.org/jira/browse/HIVE-5626
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Minor
>         Attachments: HIVE-5626.01.patch, HIVE-5626.02.patch, HIVE-5626.patch
>
>
> Metastore direct SQL is currently disabled for any queries running inside 
> external transaction (i.e. all modification queries, like dropping stuff).
> This was done to keep the strictly performance-optimization behavior when 
> using Postgres, which unlike other RDBMS-es fails the tx on any syntax error; 
> so, if direct SQL is broken there's no way to fall back. So, it is disabled 
> for these cases.
> It is not as important because drop commands are rare, but we might want to 
> address that. Either by some config setting or by making it work on 
> non-postgres DBs.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to