----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15184/#review28061 -----------------------------------------------------------
trunk/common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java <https://reviews.apache.org/r/15184/#comment54590> Can you add a comment describing that this is used to indicating to alter table command that the stats were populated by the StatsTask trunk/common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java <https://reviews.apache.org/r/15184/#comment54787> Can you add a comment describing what this param can be use for ? trunk/common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java <https://reviews.apache.org/r/15184/#comment54788> looks like there is some extra white space. trunk/common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java <https://reviews.apache.org/r/15184/#comment54589> a nit - you can avoid two hash lookups, if you do a stats_acc = params.get(COLUMN_STATS_ACCURATE) and have a if(stats_acc == null){ return false; } else { return stats_acc.equals(TRUE); } trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java <https://reviews.apache.org/r/15184/#comment54795> the update*StatsFast is not getting called from the StatsTask alterTable call stack, if stats autogather config is false. But we need to invalidate the column stats irrespective of the autogather settings. In case of fast stats, if we meet the criteria for updating stats, except for the autogather settings, I think it makes sense to invalidate the fast stats also for those. trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java <https://reviews.apache.org/r/15184/#comment54793> indentation problems in this file - Thejas Nair On Nov. 1, 2013, 6:23 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15184/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2013, 6:23 p.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-3777 > https://issues.apache.org/jira/browse/HIVE-3777 > > > Repository: hive > > > Description > ------- > > Store state of stats. > > > Diffs > ----- > > trunk/common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java > 1537954 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > 1537954 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1537954 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1537954 > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java > 1537954 > > Diff: https://reviews.apache.org/r/15184/diff/ > > > Testing > ------- > > Existing tests suffice. > > > Thanks, > > Ashutosh Chauhan > >
