----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15103/#review28140 -----------------------------------------------------------
Ship it! Ship It! - Brock Noland On Oct. 30, 2013, 8:17 p.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15103/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2013, 8:17 p.m.) > > > Review request for hive. > > > Bugs: HIVE-4523 > https://issues.apache.org/jira/browse/HIVE-4523 > > > Repository: hive-git > > > Description > ------- > > 1. Migrate old, non-generic round udf to generic udf. > 2. Addressed issues raised in the description. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 898b6a5 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/RoundWithNumDigitsDoubleToDouble.java > ca85688 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java > 120095a > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRound.java 6d5664b > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFRound.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/RoundUtils.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java > 90ab983 > ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFRound.java 992853d > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFRound.java > PRE-CREATION > ql/src/test/results/clientpositive/decimal_udf.q.out 652d1a8 > ql/src/test/results/compiler/plan/udf4.q.xml b962f7e > > Diff: https://reviews.apache.org/r/15103/diff/ > > > Testing > ------- > > Added test cases. Some old q test outputs are regenerated. > > > Thanks, > > Xuefu Zhang > >
