[ 
https://issues.apache.org/jira/browse/HIVE-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812899#comment-13812899
 ] 

Brock Noland commented on HIVE-5722:
------------------------------------

Hey Navis,

This looks good, but I think we just have the following args turned around. 
{noformat}
-      GenVectorCode.writeFile(outputFile, templateString);
+      GenVectorCode.writeFile(outputFile, new File(templateString));
{noformat}

meaning it should be:
{noformat}
GenVectorCode.writeFile(templateString, new File(outputFile));
{noformat}

correct?

> Skip generating vectorization code if possible
> ----------------------------------------------
>
>                 Key: HIVE-5722
>                 URL: https://issues.apache.org/jira/browse/HIVE-5722
>             Project: Hive
>          Issue Type: Improvement
>          Components: Build Infrastructure
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Minor
>         Attachments: HIVE-5722.1.patch.txt
>
>
> NO PRECOMMIT TESTS
> Currently, ql module always generates new vectorization code, which might not 
> be changed so frequently.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to