----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15187/ -----------------------------------------------------------
(Updated Nov. 1, 2013, 10:58 p.m.) Review request for hive. Changes ------- Incorporated review feedback. Repository: hive-git Description ------- Add src and bin descriptors to maven packaging project. Src.tar has the entire Hive source tree as is, following Apache src.tar format. Decided not to use <moduleSet> as maven only gives option to prepend the module name, which is different than the directory name in thise case. Bin.tar still does not include hcatalog stuff. It uses mvn assembly fileset to do what the ant package tasks of hive/build.xml used to do. It also uses maven's <dependencySet> to pull in dependency jars. But hive/hcatalog had a separate ant build, and there is more effort needed to include that into this mvn bin assembly in the correct directory structure. Diffs (updated) ----- packaging/pom.xml 973b351 packaging/src/main/assembly/bin.xml PRE-CREATION packaging/src/main/assembly/src.xml PRE-CREATION Diff: https://reviews.apache.org/r/15187/diff/ Testing ------- Thanks, Szehon Ho