On Nov. 1, 2013, 1:45 a.m., Xuefu Zhang wrote: > > Please also add tests to verify the result TypeInfo of the the arithmetic > > operations using various different types.
Thanks for the comments, Jason. I think the current patch is just a preview of what will be, as it's under going changes. (I wanted to start up a test run by submitting it.) Let's revisit those as the patch is in it's final form. - Xuefu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15113/#review27928 ----------------------------------------------------------- On Oct. 31, 2013, 5:43 a.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15113/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2013, 5:43 a.m.) > > > Review request for hive. > > > Bugs: HIVe-5356 > https://issues.apache.org/jira/browse/HIVe-5356 > > > Repository: hive-git > > > Description > ------- > > Replace plus, minus, and so on 6 old UDFs with generic UDF implementations. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 898b6a5 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java > 120095a > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java da01934 > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231 > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3 > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957 > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b > ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java > PRE-CREATION > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java > 4aeb4e6 > > ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java > 90ab983 > ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722 > ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java > PRE-CREATION > ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/15113/diff/ > > > Testing > ------- > > Full set of unit tests is to be run. Old testcases are also migrated. > > > Thanks, > > Xuefu Zhang > >
