----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14891/#review27821 -----------------------------------------------------------
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java <https://reviews.apache.org/r/14891/#comment54102> I think newDir is a better name for this variable. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java <https://reviews.apache.org/r/14891/#comment54113> minor nit - java for-each loop is more readable. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java <https://reviews.apache.org/r/14891/#comment54104> This is a duplicate of containsAllFastStats function. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java <https://reviews.apache.org/r/14891/#comment54223> can you add a function comment, say - "check if statistics needs to be (re)calculated" trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java <https://reviews.apache.org/r/14891/#comment54116> minor edit to comment, change " if new and old have different stats" to " if new and old have different 'fast' stats" trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java <https://reviews.apache.org/r/14891/#comment54115> I think getStatsFastCollection mgith be a better name for the function. Also that will be in line with how it is referred in rest of the code. trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java <https://reviews.apache.org/r/14891/#comment54121> Should we have a null and empty string check before passing the stats value to Long.parseLong ? Otherwise it will throw a NumberFormatException. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java <https://reviews.apache.org/r/14891/#comment54222> As this is not being used anymore we should remove it. - Thejas Nair On Oct. 23, 2013, 10:21 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14891/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2013, 10:21 p.m.) > > > Review request for hive. > > > Bugs: HIVE-3959 > https://issues.apache.org/jira/browse/HIVE-3959 > > > Repository: hive > > > Description > ------- > > Update Stats while altering table/partition > > > Diffs > ----- > > > trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStatsUtils.java > 1535192 > trunk/hbase-handler/src/test/results/positive/hbase_stats.q.out 1535192 > trunk/hbase-handler/src/test/results/positive/hbase_stats2.q.out 1535192 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > 1535192 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 1535192 > > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > 1535192 > trunk/metastore/src/java/org/apache/hadoop/hive/metastore/Warehouse.java > 1535192 > > trunk/metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java > 1535192 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java > 1535192 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 1535192 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1535192 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java > 1535192 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1535192 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorFileSinkOperator.java > 1535192 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/merge/MergeWork.java > 1535192 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/rcfile/stats/PartialScanMapper.java > 1535192 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1535192 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ConditionalResolverMergeFiles.java > 1535192 > trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/StatsFactory.java 1535192 > trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/StatsSetupConst.java > 1535192 > trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/jdbc/JDBCStatsUtils.java > 1535192 > > trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestStatsPublisherEnhanced.java > 1535192 > trunk/ql/src/test/results/clientnegative/stats_partialscan_autogether.q.out > 1535192 > trunk/ql/src/test/results/clientnegative/unset_table_property.q.out 1535192 > > trunk/ql/src/test/results/clientpositive/alter_numbuckets_partitioned_table.q.out > 1535192 > > trunk/ql/src/test/results/clientpositive/alter_numbuckets_partitioned_table2.q.out > 1535192 > > trunk/ql/src/test/results/clientpositive/alter_partition_clusterby_sortby.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/alter_partition_coltype.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/alter_skewed_table.q.out 1535192 > trunk/ql/src/test/results/clientpositive/alter_table_not_sorted.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/alter_table_serde2.q.out 1535192 > trunk/ql/src/test/results/clientpositive/auto_join_reordering_values.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/auto_sortmerge_join_1.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/auto_sortmerge_join_11.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/auto_sortmerge_join_2.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/auto_sortmerge_join_3.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/auto_sortmerge_join_4.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/auto_sortmerge_join_5.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/auto_sortmerge_join_7.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/auto_sortmerge_join_8.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/binary_output_format.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucket1.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucket2.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucket3.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucket4.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucket5.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucket_map_join_1.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucket_map_join_2.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketcontext_1.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketcontext_2.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketcontext_3.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketcontext_4.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketcontext_5.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketcontext_6.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketcontext_7.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketcontext_8.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketmapjoin1.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketmapjoin10.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketmapjoin11.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketmapjoin12.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketmapjoin13.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketmapjoin2.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketmapjoin3.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketmapjoin4.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketmapjoin5.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketmapjoin7.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketmapjoin8.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketmapjoin9.q.out 1535192 > trunk/ql/src/test/results/clientpositive/bucketmapjoin_negative.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/bucketmapjoin_negative2.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/bucketmapjoin_negative3.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/bucketsortoptimize_insert_2.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/bucketsortoptimize_insert_3.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/bucketsortoptimize_insert_5.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/bucketsortoptimize_insert_7.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/bucketsortoptimize_insert_8.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/columnstats_partlvl.q.out 1535192 > trunk/ql/src/test/results/clientpositive/columnstats_tbllvl.q.out 1535192 > trunk/ql/src/test/results/clientpositive/combine2_hadoop20.q.out 1535192 > > trunk/ql/src/test/results/clientpositive/create_alter_list_bucketing_table1.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/create_like_view.q.out 1535192 > trunk/ql/src/test/results/clientpositive/ctas_colname.q.out 1535192 > trunk/ql/src/test/results/clientpositive/ctas_hadoop20.q.out 1535192 > trunk/ql/src/test/results/clientpositive/ctas_uses_database_location.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/describe_comment_nonascii.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/describe_table.q.out 1535192 > trunk/ql/src/test/results/clientpositive/disable_merge_for_bucketing.q.out > 1535192 > > trunk/ql/src/test/results/clientpositive/dynamic_partition_skip_default.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/filter_join_breaktask.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/groupby_map_ppr.q.out 1535192 > > trunk/ql/src/test/results/clientpositive/groupby_map_ppr_multi_distinct.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/groupby_ppr.q.out 1535192 > trunk/ql/src/test/results/clientpositive/groupby_ppr_multi_distinct.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/groupby_sort_1.q.out 1535192 > trunk/ql/src/test/results/clientpositive/groupby_sort_6.q.out 1535192 > trunk/ql/src/test/results/clientpositive/groupby_sort_skew_1.q.out 1535192 > trunk/ql/src/test/results/clientpositive/infer_bucket_sort.q.out 1535192 > trunk/ql/src/test/results/clientpositive/infer_bucket_sort_dyn_part.q.out > 1535192 > > trunk/ql/src/test/results/clientpositive/infer_bucket_sort_map_operators.q.out > 1535192 > > trunk/ql/src/test/results/clientpositive/infer_bucket_sort_multi_insert.q.out > 1535192 > > trunk/ql/src/test/results/clientpositive/infer_bucket_sort_reducers_power_two.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/input23.q.out 1535192 > trunk/ql/src/test/results/clientpositive/input42.q.out 1535192 > trunk/ql/src/test/results/clientpositive/input_part1.q.out 1535192 > trunk/ql/src/test/results/clientpositive/input_part2.q.out 1535192 > trunk/ql/src/test/results/clientpositive/input_part7.q.out 1535192 > trunk/ql/src/test/results/clientpositive/input_part9.q.out 1535192 > trunk/ql/src/test/results/clientpositive/insert_into5.q.out 1535192 > trunk/ql/src/test/results/clientpositive/join17.q.out 1535192 > trunk/ql/src/test/results/clientpositive/join26.q.out 1535192 > trunk/ql/src/test/results/clientpositive/join32.q.out 1535192 > trunk/ql/src/test/results/clientpositive/join32_lessSize.q.out 1535192 > trunk/ql/src/test/results/clientpositive/join33.q.out 1535192 > trunk/ql/src/test/results/clientpositive/join34.q.out 1535192 > trunk/ql/src/test/results/clientpositive/join35.q.out 1535192 > trunk/ql/src/test/results/clientpositive/join9.q.out 1535192 > trunk/ql/src/test/results/clientpositive/join_filters_overlap.q.out 1535192 > trunk/ql/src/test/results/clientpositive/join_map_ppr.q.out 1535192 > trunk/ql/src/test/results/clientpositive/list_bucket_dml_10.q.out 1535192 > trunk/ql/src/test/results/clientpositive/load_dyn_part8.q.out 1535192 > trunk/ql/src/test/results/clientpositive/louter_join_ppr.q.out 1535192 > trunk/ql/src/test/results/clientpositive/macro.q.out 1535192 > trunk/ql/src/test/results/clientpositive/merge3.q.out 1535192 > trunk/ql/src/test/results/clientpositive/merge4.q.out 1535192 > trunk/ql/src/test/results/clientpositive/outer_join_ppr.q.out 1535192 > trunk/ql/src/test/results/clientpositive/parallel_orderby.q.out 1535192 > trunk/ql/src/test/results/clientpositive/partition_date2.q.out 1535192 > trunk/ql/src/test/results/clientpositive/pcr.q.out 1535192 > trunk/ql/src/test/results/clientpositive/ppd_join_filter.q.out 1535192 > trunk/ql/src/test/results/clientpositive/ppd_union_view.q.out 1535192 > trunk/ql/src/test/results/clientpositive/ppd_vc.q.out 1535192 > trunk/ql/src/test/results/clientpositive/ppr_allchildsarenull.q.out 1535192 > trunk/ql/src/test/results/clientpositive/push_or.q.out 1535192 > trunk/ql/src/test/results/clientpositive/rand_partitionpruner1.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/rand_partitionpruner2.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/rand_partitionpruner3.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/rcfile_default_format.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/reduce_deduplicate.q.out 1535192 > trunk/ql/src/test/results/clientpositive/regexp_extract.q.out 1535192 > trunk/ql/src/test/results/clientpositive/router_join_ppr.q.out 1535192 > trunk/ql/src/test/results/clientpositive/sample1.q.out 1535192 > trunk/ql/src/test/results/clientpositive/sample10.q.out 1535192 > trunk/ql/src/test/results/clientpositive/sample2.q.out 1535192 > trunk/ql/src/test/results/clientpositive/sample4.q.out 1535192 > trunk/ql/src/test/results/clientpositive/sample5.q.out 1535192 > trunk/ql/src/test/results/clientpositive/sample6.q.out 1535192 > trunk/ql/src/test/results/clientpositive/sample7.q.out 1535192 > trunk/ql/src/test/results/clientpositive/sample8.q.out 1535192 > trunk/ql/src/test/results/clientpositive/sample9.q.out 1535192 > trunk/ql/src/test/results/clientpositive/serde_user_properties.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/show_create_table_alter.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/show_create_table_serde.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/show_tblproperties.q.out 1535192 > trunk/ql/src/test/results/clientpositive/smb_mapjoin_11.q.out 1535192 > trunk/ql/src/test/results/clientpositive/smb_mapjoin_12.q.out 1535192 > trunk/ql/src/test/results/clientpositive/smb_mapjoin_13.q.out 1535192 > trunk/ql/src/test/results/clientpositive/smb_mapjoin_15.q.out 1535192 > trunk/ql/src/test/results/clientpositive/smb_mapjoin_18.q.out 1535192 > trunk/ql/src/test/results/clientpositive/sort_merge_join_desc_5.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/sort_merge_join_desc_6.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/sort_merge_join_desc_7.q.out > 1535192 > trunk/ql/src/test/results/clientpositive/stats0.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats1.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats10.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats11.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats12.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats13.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats14.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats15.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats16.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats2.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats20.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats3.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats4.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats5.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats6.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats7.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats8.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats9.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats_noscan_1.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats_noscan_2.q.out 1535192 > trunk/ql/src/test/results/clientpositive/stats_partscan_1.q.out 1535192 > trunk/ql/src/test/results/clientpositive/transform_ppr1.q.out 1535192 > trunk/ql/src/test/results/clientpositive/transform_ppr2.q.out 1535192 > trunk/ql/src/test/results/clientpositive/truncate_column.q.out 1535192 > trunk/ql/src/test/results/clientpositive/udf_explode.q.out 1535192 > trunk/ql/src/test/results/clientpositive/udf_java_method.q.out 1535192 > trunk/ql/src/test/results/clientpositive/udf_reflect.q.out 1535192 > trunk/ql/src/test/results/clientpositive/udf_reflect2.q.out 1535192 > trunk/ql/src/test/results/clientpositive/udtf_explode.q.out 1535192 > trunk/ql/src/test/results/clientpositive/union22.q.out 1535192 > trunk/ql/src/test/results/clientpositive/union24.q.out 1535192 > trunk/ql/src/test/results/clientpositive/union_ppr.q.out 1535192 > trunk/ql/src/test/results/clientpositive/unset_table_view_property.q.out > 1535192 > trunk/ql/src/test/results/compiler/plan/case_sensitivity.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/cast1.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/groupby1.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/groupby2.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/groupby3.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/groupby4.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/groupby5.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/groupby6.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/input1.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/input2.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/input20.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/input3.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/input4.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/input5.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/input6.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/input7.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/input8.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/input9.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/input_part1.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/input_testsequencefile.q.xml > 1535192 > trunk/ql/src/test/results/compiler/plan/input_testxpath.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/input_testxpath2.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/join1.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/join2.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/join3.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/join4.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/join5.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/join6.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/join7.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/join8.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/sample1.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/sample2.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/sample3.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/sample4.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/sample5.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/sample6.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/sample7.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/subq.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/udf1.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/udf6.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/udf_case.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/udf_when.q.xml 1535192 > trunk/ql/src/test/results/compiler/plan/union.q.xml 1535192 > > Diff: https://reviews.apache.org/r/14891/diff/ > > > Testing > ------- > > existing tests suffice, since no new functionality > > > Thanks, > > Ashutosh Chauhan > >
