> On Oct. 28, 2013, 8:43 p.m., Brock Noland wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java, line > > 2936 > > <https://reviews.apache.org/r/14970/diff/2/?file=372522#file372522line2936> > > > > Is this what we want? I was assume we only wanted to log the exception > > at this point since it's not being logged.
Hi Brock, the exception is still being logged in the catch block, and was logged even before, that behavior did not change. But the problem is, the logging catch block eats the exception, losing the information. Then, it causes a NPE down the line also in the same method (line 2949: if parts.isEmpty()). I read the JIRA to be to throw the correct exception which today is being eaten and lost, and to not throw the misleading NPE. Or am I misunderstanding it? Thank you. - Szehon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14970/#review27634 ----------------------------------------------------------- On Oct. 28, 2013, 8:40 p.m., Szehon Ho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14970/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2013, 8:40 p.m.) > > > Review request for hive. > > > Bugs: HIVE-4723 > https://issues.apache.org/jira/browse/HIVE-4723 > > > Repository: hive-git > > > Description > ------- > > Throwing the offending exception, that was swallowed. Also changing the > underlying exception to use the standard error message. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java b0f124b > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 037191a > ql/src/test/results/clientnegative/alter_rename_partition_failure3.q.out > 384fcbe > ql/src/test/results/clientnegative/touch2.q.out 045121a > > Diff: https://reviews.apache.org/r/14970/diff/ > > > Testing > ------- > > > Thanks, > > Szehon Ho > >
