[
https://issues.apache.org/jira/browse/HIVE-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13807021#comment-13807021
]
Ashutosh Chauhan commented on HIVE-5671:
----------------------------------------
Reason for checking in {{OrcProto.java}} is same as checking in thrift
generated code which is if not checked in then that implies devs need to have
thrift compiler (for thrift generated code) and protobuf compiler (for
protobuf generated code) to be installed on their machine. In the past, many
devs have felt that installing thrift compiler or protobuf compiler is
complicated enough that if possible we should avoid the burden of having it
installed. Also, having this requirement will be impediment for new hive devs.
> Generated src OrcProto.java shouldn't be in the source control
> --------------------------------------------------------------
>
> Key: HIVE-5671
> URL: https://issues.apache.org/jira/browse/HIVE-5671
> Project: Hive
> Issue Type: Improvement
> Components: Build Infrastructure
> Affects Versions: 0.12.0
> Reporter: Xuefu Zhang
> Assignee: Xuefu Zhang
>
> orc_proto.proto generates OrcProto.java, which unfortunately made its way to
> source control, so changing the .proto file requires regenerating the .java
> file and checking it in again. This is unnecessary.
> Also, the code generation should be part of the build process.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
