[ https://issues.apache.org/jira/browse/HIVE-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806821#comment-13806821 ]
Brock Noland commented on HIVE-5663: ------------------------------------ Yep I saw that and I think keeping in line with the existing code base is a great goal. However, I don't think that makes sense when there is redundant or non-standard code like this case. Thanks for the contribution! > Refactor ORC RecordReader to operate on direct & wrapped ByteBuffers > -------------------------------------------------------------------- > > Key: HIVE-5663 > URL: https://issues.apache.org/jira/browse/HIVE-5663 > Project: Hive > Issue Type: Improvement > Components: File Formats > Affects Versions: 0.13.0 > Environment: Ubuntu LXC > Reporter: Gopal V > Assignee: Gopal V > Labels: ORC > Attachments: HIVE-5663.01.patch > > > The current ORC RecordReader implementation assumes array structures backing > the ByteBuffers it passes around between RecordReaderImpl and > Compressed/Uncompressed InStream objects. > This patch attempts to refactor those assumptions out of both classes, > allowing the future use of direct byte buffers within ORC (as might come from > HDFS zero-copy readers). -- This message was sent by Atlassian JIRA (v6.1#6144)