----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14985/#review27598 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcStruct.java <https://reviews.apache.org/r/14985/#comment53625> This will cause existing decimal data to not be readable, so probably not best to throw exception here. Or were you planning to change this in HIVE-5564? Are there any existing orc/decimal tests? Otherwise might be good to test that the precision/scale is preserved correctly for ORC. - Jason Dere On Oct. 28, 2013, 4:49 a.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14985/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2013, 4:49 a.m.) > > > Review request for hive and Brock Noland. > > > Bugs: HIVE-5354 > https://issues.apache.org/jira/browse/HIVE-5354 > > > Repository: hive-git > > > Description > ------- > > Support decimal precision/scale for Orc file, as part of HIVE-3976. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcStruct.java c993b37 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java 71484a3 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java 7519fc1 > ql/src/protobuf/org/apache/hadoop/hive/ql/io/orc/orc_proto.proto 53b93a0 > > Diff: https://reviews.apache.org/r/14985/diff/ > > > Testing > ------- > > > Thanks, > > Xuefu Zhang > >
