----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14484/#review27500 -----------------------------------------------------------
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java <https://reviews.apache.org/r/14484/#comment53425> As confoverlay wasn't happening before there is no asyn specific test to verify. But I agree, that in general we need more concurrency tests that also use these features. We should take that up in another jira. - Thejas Nair On Oct. 4, 2013, 7:16 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14484/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2013, 7:16 a.m.) > > > Review request for hive. > > > Bugs: HIVE-5440 > https://issues.apache.org/jira/browse/HIVE-5440 > > > Repository: hive-git > > > Description > ------- > > The patch clones the session config object and applies the specified > per-operation properties, if any. This way the changes are applicable to the > current driver and not to the parent session. The patch also extends this for > the async query to isolate the session and query config. > > > Diffs > ----- > > > service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java > 6b5a5c3 > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java > bb0f711 > service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 794ede8 > > Diff: https://reviews.apache.org/r/14484/diff/ > > > Testing > ------- > > Added new test cases for the patch > > > Thanks, > > Prasad Mujumdar > >
