[
https://issues.apache.org/jira/browse/HIVE-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804433#comment-13804433
]
Prasad Mujumdar commented on HIVE-5641:
---------------------------------------
LGTM
+1 (non-binding)
> BeeLineOpts ignores Throwable
> -----------------------------
>
> Key: HIVE-5641
> URL: https://issues.apache.org/jira/browse/HIVE-5641
> Project: Hive
> Issue Type: Bug
> Reporter: Brock Noland
> Assignee: Brock Noland
> Priority: Minor
> Attachments: HIVE-5641.patch
>
>
> BeelineOpts has the following code:
> {noformat}
> } catch (Throwable t) {
> return -1;
> }
> {noformat}
> which is bad. I believe it is there because the code called maybe buggy and
> throw such things as ArrayIndex or NoSuchElement etc.
> I propose we:
> 1) catch exception, not throwable. Usage should remain the same without
> having a giant black hole
> 2) that we log the exception so we can figure out what is wrong with the
> underlying code
--
This message was sent by Atlassian JIRA
(v6.1#6144)
