[ 
https://issues.apache.org/jira/browse/HIVE-5403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13802959#comment-13802959
 ] 

Brock Noland commented on HIVE-5403:
------------------------------------

Hey guys, thank you very much for your work on this!  I know this is already 
committed, but the following is incorrect:
{noformat}
+    // session creation should fail since the schema didn't get created
+    try {
+      SessionState.start(new CliSessionState(hiveConf));
+    } catch (RuntimeException re) {
+      assertTrue(re.getCause().getCause() instanceof MetaException);
+    }
{noformat}
It should be

{noformat}
+    // session creation should fail since the schema didn't get created
+    try {
+      SessionState.start(new CliSessionState(hiveConf));
        fail("Expected exception");
+    } catch (RuntimeException re) {
+      assertTrue(re.getCause().getCause() instanceof MetaException);
+    }
{noformat}

Can you do a follow up jira?

> Move loading of filesystem, ugi, metastore client to hive session
> -----------------------------------------------------------------
>
>                 Key: HIVE-5403
>                 URL: https://issues.apache.org/jira/browse/HIVE-5403
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.13.0
>            Reporter: Vikram Dixit K
>            Assignee: Vikram Dixit K
>             Fix For: 0.13.0
>
>         Attachments: HIVE-5403.1.patch, HIVE-5403.2.patch, HIVE-5403.3.patch, 
> HIVE-5403.4.patch
>
>
> As part of HIVE-5184, the metastore connection, loading filesystem were done 
> as part of the tez session so as to speed up query times while paying a cost 
> at startup. We can do this more generally in hive to apply to both the 
> mapreduce and tez side of things.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to