0 IMO phabricator interface is better than review board, but threat of losing comments and patches is also real. Actually, we already lost in few cases, ironically it was RB. Try to read the very first review request posted on HIVE-1634
Ashutosh On Thu, Oct 17, 2013 at 6:55 PM, Yin Huai <huaiyin....@gmail.com> wrote: > +1 > > > On Thu, Oct 17, 2013 at 5:51 PM, Gunther Hagleitner < > ghagleit...@hortonworks.com> wrote: > > > +1 > > > > Thanks, > > Gunther. > > > > > > On Thu, Oct 17, 2013 at 2:18 PM, Owen O'Malley <omal...@apache.org> > wrote: > > > > > Ed, > > > I didn't remember being unable to see revisions without a login. That > > is > > > uncool. I'll change my vote to +1. > > > > > > -- Owen > > > > > > > > > On Wed, Oct 16, 2013 at 9:08 PM, Edward Capriolo < > edlinuxg...@gmail.com > > > >wrote: > > > > > > > Owen, > > > > In your issues: > > > > https://issues.apache.org/jira/browse/HIVE-5567 > > > > > > > > When I click this link: > > > > REVISION DETAIL > > > > https://reviews.facebook.net/D13479 > > > > > > > > I am prompted for a password. > > > > > > > > > > > > > > > > On Wed, Oct 16, 2013 at 11:16 PM, Owen O'Malley < > > owen.omal...@gmail.com > > > > >wrote: > > > > > > > > > -0 > > > > > > > > > > I like phabricator, but it is a pain to setup. It doesn't require a > > fb > > > > > account, but clearly it isn't managed or supported by Apache. > > > > > > > > > > -- Owen > > > > > > > > > > > On Oct 16, 2013, at 17:32, Edward Capriolo < > edlinuxg...@gmail.com> > > > > > wrote: > > > > > > > > > > > > Our wiki has instructions for posting to phabricator for code > > > reviews. > > > > > > > > > https://cwiki.apache.org/confluence/display/Hive/PhabricatorCodeReview > > > > > > > > > > > > Phabricator now requires an external facebook account to review > > > > patches, > > > > > > and we have no technical support contact where phabricator is > > hosted. > > > > It > > > > > > also seems like some of the phabricator features are no longer > > > working. > > > > > > > > > > > > Apache has a review board system many people are already using. > > > > > > https://reviews.apache.org/account/login/?next_page=/dashboard/ > > > > > > > > > > > > This vote is to remove the phabricator instructions from the > wiki. > > > The > > > > > > instructions will reference review board and that will be the > only > > > > system > > > > > > that Hive supports for patch review process. > > > > > > > > > > > > +1 is a vote for removing the phabricator instructions from the > > wiki. > > > > > > > > > > > > Thank you, > > > > > > Edward > > > > > > > > > > > > > > > > -- > > CONFIDENTIALITY NOTICE > > NOTICE: This message is intended for the use of the individual or entity > to > > which it is addressed and may contain information that is confidential, > > privileged and exempt from disclosure under applicable law. If the reader > > of this message is not the intended recipient, you are hereby notified > that > > any printing, copying, dissemination, distribution, disclosure or > > forwarding of this communication is strictly prohibited. If you have > > received this communication in error, please contact the sender > immediately > > and delete it from your system. Thank You. > > >
