[
https://issues.apache.org/jira/browse/HIVE-5510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794758#comment-13794758
]
Eugene Koifman commented on HIVE-5510:
--------------------------------------
There should be some JavaDoc (either on ListDelegator or StatusDelegator) that
has a few lines about the design:
What is being tracked for parent job (presumably LauchMapper?), what (if
anything) is tracked for child job(s).
While not strictly related to this bug, there should be some comments on what
will happen if a user (StatusDelegator) asks for a status of a job he doesn't
own.
There are no new tests in this patch. Is this covered by existing tests?
TempletonControllerJob has
if (childid != null) {
+ JobState childState = new JobState(childid, conf);
+ childState.setParent(jobid.toString());
+ state.close();
+ state.addChild(childid);
+ }
why is state.close() before state.addChild ?
DeleteDelegaor
has "String childid = state.getChildId();" which is unused.
Also, wouldn't make sense to wrap killJob() in a try/catch inside the loop so
that we cancel as many child tasks as possible?
ListDelegator
JobState state = null; - this variable is never used and thus it and the
try/finally is unused
> [WebHCat] GET job/queue return wrong job information
> ----------------------------------------------------
>
> Key: HIVE-5510
> URL: https://issues.apache.org/jira/browse/HIVE-5510
> Project: Hive
> Issue Type: Bug
> Components: WebHCat
> Affects Versions: 0.12.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.13.0
>
> Attachments: HIVE-5510-1.patch
>
>
> GET job/queue of a TempletonController job return weird information. It is a
> mix of child job and itself. It should only pull the information of the
> controller job itself.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
