----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14590/ -----------------------------------------------------------
Review request for hive and Ashutosh Chauhan. Bugs: HIVE-5520 https://issues.apache.org/jira/browse/HIVE-5520 Repository: hive-git Description ------- Refactoring the code to use static factory methods to replace existing constructors. Diffs ----- common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java e5a35cd ql/src/java/org/apache/hadoop/hive/ql/io/orc/ColumnStatisticsImpl.java 42d897c ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java fe1845c ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java 6caef3f ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcFile.java 1dfcb56 ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSerDeStats.java bd9ea21 ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFAbs.java 3b4a7ac serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java add5bdf serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java 5b18c8f serde/src/java/org/apache/hadoop/hive/serde2/io/HiveDecimalWritable.java 81500a8 serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveDecimal.java 08f251c serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveDecimalObjectInspector.java 92e47fa serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java 9a93740 serde/src/test/org/apache/hadoop/hive/serde2/binarysortable/TestBinarySortableSerDe.java 82feeec serde/src/test/org/apache/hadoop/hive/serde2/io/TestTimestampWritable.java e54c105 serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestObjectInspectorConverters.java 5e546c5 Diff: https://reviews.apache.org/r/14590/diff/ Testing ------- No new tests necessary. Waiting for pre-commit test results. Thanks, Xuefu Zhang