[ 
https://issues.apache.org/jira/browse/HIVE-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13785836#comment-13785836
 ] 

Hudson commented on HIVE-5413:
------------------------------

SUCCESS: Integrated in Hive-trunk-hadoop1-ptest #189 (See 
[https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/189/])
HIVE-5413 : StorageDelegationAuthorizationProvider uses non-existent 
org.apache.hive.hcatalog.hbase.HBaseHCatStorageHandler (Eugene Koifman via 
Sushanth Sowmyan) (khorgath: 
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1528633)
* /hive/trunk/hcatalog/conf/proto-hive-site.xml
* 
/hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/security/HdfsAuthorizationProvider.java
* 
/hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/security/StorageDelegationAuthorizationProvider.java
* 
/hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/security/HdfsAuthorizationProvider.java
* 
/hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/security/StorageDelegationAuthorizationProvider.java
* 
/hive/trunk/hcatalog/core/src/test/java/org/apache/hcatalog/security/TestHdfsAuthorizationProvider.java
* 
/hive/trunk/hcatalog/core/src/test/java/org/apache/hive/hcatalog/security/TestHdfsAuthorizationProvider.java
* /hive/trunk/hcatalog/src/test/e2e/hcatalog/tests/hadoop.conf
* /hive/trunk/hcatalog/src/test/e2e/hcatalog/tests/pig.conf
* 
/hive/trunk/hcatalog/src/test/e2e/hcatalog/udfs/java/org/apache/hcatalog/utils/HBaseReadWrite.java
* 
/hive/trunk/hcatalog/src/test/e2e/hcatalog/udfs/java/org/apache/hive/hcatalog/utils/HBaseReadWrite.java
* 
/hive/trunk/hcatalog/src/test/e2e/hcatalog/udfs/java/org/apache/hive/hcatalog/utils/WriteTextPartitioned.java
* /hive/trunk/hcatalog/src/test/e2e/templeton/README.txt
* 
/hive/trunk/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/HBaseAuthorizationProvider.java


> StorageDelegationAuthorizationProvider uses non-existent 
> org.apache.hive.hcatalog.hbase.HBaseHCatStorageHandler
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-5413
>                 URL: https://issues.apache.org/jira/browse/HIVE-5413
>             Project: Hive
>          Issue Type: Bug
>          Components: HCatalog
>    Affects Versions: 0.12.0
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>             Fix For: 0.12.0
>
>         Attachments: HIVE-5413.patch
>
>
> org.apache.hive.hcatalog.security.StorageDelegationAuthorizationProvider
> has a block like this:
>   static {
>     registerAuthProvider("org.apache.hadoop.hive.hbase.HBaseStorageHandler",
>       "org.apache.hive.hcatalog.hbase.HBaseAuthorizationProvider");
>     
> registerAuthProvider("org.apache.hive.hcatalog.hbase.HBaseHCatStorageHandler",
>       "org.apache.hive.hcatalog.hbase.HBaseAuthorizationProvider");
>   }
> In reality, HBaseHCatStorageHandler and HBaseAuthorizationProvider only exist 
> in org.apache.hcatalog
> This should be fixed by removing 
> org.apache.hive.hcatalog.security.StorageDelegationAuthorizationProvider.  We 
> have org.apache.hcatalog.security.StorageDelegationAuthorizationProvider 
> which is only used by now deprecated hcatalog version of hbase storage 
> handler.
> Also,
> hcatalog/src/test/e2e/hcatalog/tests/pig.conf & hadoop.conf have the same 
> problem.  
> In addition, the tests affected in pig.conf/hadoop.conf should use 
> org.apache.hcatalog.pig.HCatLoader/HCatStorer.
> Finally, hadoop.conf#Hadoop_HBase is using 
> org.apache.hive.hcatalog.utils.HBaseReadWrite which internally refers to 
> org.apache.hive.hcatalog.* classes.  The later should only use 
> org.apache.hcatalog.* since it's using HBaseHCatStoreageHandler.  Also, 
> should move HBaseReadWrite to org.apache.hcatalog for clarity.
> (see the last paragraph of the Description of HIVE-5274)



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to