----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14425/#review26542 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java <https://reviews.apache.org/r/14425/#comment51790> instead of putting this comment there... why not add a public method to load/create the meta store client. that one can be used by anyone. (maybe just change the visibility of createMetaStoreClient) - Gunther Hagleitner On Oct. 1, 2013, 1:38 a.m., Vikram Dixit Kumaraswamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14425/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2013, 1:38 a.m.) > > > Review request for hive and Gunther Hagleitner. > > > Bugs: HIVE-5403 > https://issues.apache.org/jira/browse/HIVE-5403 > > > Repository: hive-git > > > Description > ------- > > Move loading of filesystem, ugi, metastore client to hive session. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 0491f8b > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java f6b1491 > > Diff: https://reviews.apache.org/r/14425/diff/ > > > Testing > ------- > > Does not affect any unit tests but all of them exercise this code path. > > > Thanks, > > Vikram Dixit Kumaraswamy > >