[ 
https://issues.apache.org/jira/browse/HIVE-5114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Brock Noland updated HIVE-5114:
-------------------------------

    Attachment: HIVE-5114.2.patch

Sergey,

Great patch!! I tested it and works great with one exception. The qfile tests 
we generate is based on the property "qfile" at test gen time and if it does 
not exist, we generate a test for all the qfiles. This means that later you 
cannot run just a single qfile with testonly.

So I have I have done, is taken my changes to fix this, created for HIVE-5396, 
and grafted them onto your patch as HIVE-5114.2.patch. The changes are follows:

1) Current qfile tests print to both syserr and sysout. Fix this and a few very 
minor other cleanups.
2) Decide which tests for qfile tests to execute at runtime based on the qfile 
property.
3) Don't store fully qualified paths in the qfile tests (required for ptest)

Thoughts on the wider patch?

Brock

> add a target to run tests without rebuilding them
> -------------------------------------------------
>
>                 Key: HIVE-5114
>                 URL: https://issues.apache.org/jira/browse/HIVE-5114
>             Project: Hive
>          Issue Type: Improvement
>          Components: Build Infrastructure
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-5114.2.patch, HIVE-5114.D12399.1.patch
>
>
> it is sometimes annoying that each "ant test ..." cleans and rebuilds the 
> tests. It is should be relatively easy to add a "testonly" target that would 
> just run the test(s) on the existing build



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to