[ https://issues.apache.org/jira/browse/HIVE-5370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-5370: ------------------------------ Attachment: D13185.1.patch Amareshwari requested code review of "HIVE-5370 [jira] format_number udf should take user specifed format as argument". Reviewers: JIRA Support format as second argument for format_number udf Currently, format_number udf formats the number to #,###,###.##, but it should also take a user specified format as optional input. TEST PLAN Unit test updated REVISION DETAIL https://reviews.facebook.net/D13185 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFFormatNumber.java ql/src/test/queries/clientpositive/udf_format_number.q ql/src/test/results/clientpositive/udf_format_number.q.out MANAGE HERALD RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/38649/ To: JIRA, Amareshwari > format_number udf should take user specifed format as argument > -------------------------------------------------------------- > > Key: HIVE-5370 > URL: https://issues.apache.org/jira/browse/HIVE-5370 > Project: Hive > Issue Type: Improvement > Components: UDF > Reporter: Amareshwari Sriramadasu > Assignee: Amareshwari Sriramadasu > Priority: Minor > Attachments: D13185.1.patch > > > Currently, format_number udf formats the number to #,###,###.##, but it > should also take a user specified format as optional input. -- This message was sent by Atlassian JIRA (v6.1#6144)