[ 
https://issues.apache.org/jira/browse/HIVE-5374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13779514#comment-13779514
 ] 

Prasad Mujumdar commented on HIVE-5374:
---------------------------------------

Looks fine me. Thanks for the fix!

+1 (non-binding)

                
> hive-schema-0.13.0.postgres.sql doesn't work
> --------------------------------------------
>
>                 Key: HIVE-5374
>                 URL: https://issues.apache.org/jira/browse/HIVE-5374
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.12.0, 0.13.0
>            Reporter: Kousuke Saruta
>             Fix For: 0.12.0, 0.13.0
>
>         Attachments: HIVE-5374.patch.1, HIVE-5374.patch.2
>
>
> hive-schema-0.13.0.postgres.sql doesn't work. In PostgreSQL, if we double 
> quote keyword (colmn name, table name etc ), those names are treated case 
> sensitively. But in the script, there is a non double quoted table name and 
> column anme although those are double quoted at the definition.
> {code}
> CREATE TABLE "VERSION" (
>   "VER_ID" bigint,
>   "SCHEMA_VERSION" character varying(127) NOT NULL,
>   "COMMENT" character varying(255) NOT NULL,
>   PRIMARY KEY ("VER_ID")
> );
> {code}
> {code}
> INSERT INTO VERSION (VER_ID, SCHEMA_VERSION, VERSION_COMMENT) VALUES (1, 
> '0.13.0', 'Hive release version 0.13.0');
> {code}
> Also, the definition above defines column "COMMENT" but I think it should be 
> named "VERSION_COMMENT".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to