[ 
https://issues.apache.org/jira/browse/HIVE-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13777667#comment-13777667
 ] 

Brock Noland commented on HIVE-5253:
------------------------------------

One of the huge downsides of the current build is that we cannot detect the 
difference between something that fails to compile and a check style violation. 
Since your patch does not introduce them, it looks like there are violations on 
trunk at present. See below.

{noformat}
checkstyle:
     [echo] hcatalog
[checkstyle] Running Checkstyle 5.5 on 613 files
[checkstyle] 
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/core/src/main/java/org/apache/hcatalog/common/HCatUtil.java:453:
 method def child at indentation level 6 not at correct indentation, 4
[checkstyle] 
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/core/src/main/java/org/apache/hcatalog/common/HCatUtil.java:454:
 method def child at indentation level 6 not at correct indentation, 4
[checkstyle] 
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/core/src/main/java/org/apache/hcatalog/common/HCatUtil.java:455:
 method def child at indentation level 6 not at correct indentation, 4
[checkstyle] 
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/core/src/main/java/org/apache/hcatalog/common/HCatUtil.java:456:
 method call child at indentation level 6 not at correct indentation, 8
[checkstyle] 
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java:486:
 method def child at indentation level 3 not at correct indentation, 4
[checkstyle] 
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java:487:
 method call child at indentation level 3 not at correct indentation, 4
[checkstyle] 
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java:487:
 method def child at indentation level 3 not at correct indentation, 4
[checkstyle] 
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HCatUtil.java:488:
 method def child at indentation level 3 not at correct indentation, 4
      [for] hcatalog: The following error occurred while executing this line:
      [for] /data/hive-ptest/working/apache-svn-trunk-source/build.xml:355: The 
following error occurred while executing this line:
      [for] 
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/build.xml:127: The 
following error occurred while executing this line:
      [for] 
/data/hive-ptest/working/apache-svn-trunk-source/hcatalog/build-support/ant/checkstyle.xml:32:
 Got 8 errors and 0 warnings.
{noformat}
                
> Create component to compile and jar dynamic code
> ------------------------------------------------
>
>                 Key: HIVE-5253
>                 URL: https://issues.apache.org/jira/browse/HIVE-5253
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>         Attachments: HIVE-5253.1.patch.txt, HIVE-5253.3.patch.txt, 
> HIVE-5253.3.patch.txt, HIVE-5253.3.patch.txt, HIVE-5253.patch.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to