[ 
https://issues.apache.org/jira/browse/HIVE-5327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13772637#comment-13772637
 ] 

Edward Capriolo commented on HIVE-5327:
---------------------------------------

Couple things not so hot here:
1) strings repeated 4 times (moved to constant)
2) Stream could be leaked under assert condition
3) assert condition should probably explode rather then putting null in work map
4) e.printStackTrace() in code.
                
> Potential leak and cleanup in utilities.java
> --------------------------------------------
>
>                 Key: HIVE-5327
>                 URL: https://issues.apache.org/jira/browse/HIVE-5327
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>            Priority: Minor
>         Attachments: HIVE-5327.patch.txt
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to