[ https://issues.apache.org/jira/browse/HIVE-5294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769559#comment-13769559 ]
Brock Noland commented on HIVE-5294: ------------------------------------ This looks good! I wander about the aggregation buffer constructor, specifically: Log.error("buffer type was null"); Won't this lead to a NPE later? If so, should we just throw a RuntimeException? > Create collect UDF and make evaluator reusable > ---------------------------------------------- > > Key: HIVE-5294 > URL: https://issues.apache.org/jira/browse/HIVE-5294 > Project: Hive > Issue Type: New Feature > Reporter: Edward Capriolo > Assignee: Edward Capriolo > Attachments: HIVE-5294.patch.txt > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira