[ https://issues.apache.org/jira/browse/HIVE-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-5265: ------------------------------ Attachment: HIVE-5265.D12861.1.patch sershe requested code review of "HIVE-5265 [jira] Direct SQL fallback broken on Postgres". Reviewers: JIRA Preliminary patch. I think this needs to go in as part of 0.12. I am running tests now, it will take a while. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D12861 AFFECTED FILES metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java MANAGE HERALD RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/30819/ To: JIRA, sershe > Direct SQL fallback broken on Postgres > -------------------------------------- > > Key: HIVE-5265 > URL: https://issues.apache.org/jira/browse/HIVE-5265 > Project: Hive > Issue Type: Bug > Affects Versions: 0.12.0 > Reporter: Sergey Shelukhin > Assignee: Sergey Shelukhin > Priority: Critical > Attachments: HIVE-5265.D12861.1.patch > > > See HIVE-5264. Postgres aborts transaction on any failed query, so the > fallback doesn't work. > Original code used to do rollback/restart tx on SQL failure, but then it was > removed to allow usage in cases like dropTable/etc., where there's external > tx present and we cannot partially rollback. > Looks like the solution for now is to reinstate the rollback/reopen, and > prohibit the usage inside external transactions. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira