[
https://issues.apache.org/jira/browse/HIVE-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13763773#comment-13763773
]
Sushanth Sowmyan commented on HIVE-5260:
----------------------------------------
Per discussions between Viraj, Ashutosh and myself, we need a couple more
changes on this patch. Viraj is currently respinning his patch with these
changes:
Line numbers addendum to Ashutosh's original review:
73 : ok
105 : can be improved by doing inner-if once, but will not require respinning
by itself. If we have to respin though, we should do this.
configureTableJobProperties : HBaseConfiguration.addHbaseResources seems to
take Configuration, which makes it unnecessary to create copyOfConf. In this
case, avoid copy, and avoid the if two lines later as well, where we check if
it's an instance of JobConf or not. Respin.
> possible to change addHBaseDelegationToken to accept Configuration,
and instantiate a JobContext to pass into
User.getCurrent().obtainAuthTokenForJob(conf,job) form.
341 : similar comment
Refactor to do similar things outside the if(), and only different things
inside the if-else for inputjobprops/outputjobprops
100 : fine
123 : replace concurrenthashmap with string, keep in hivefileformatutils
> Introduce HivePassThroughOutputFormat that allows Hive to use general purpose
> OutputFormats instead of HiveOutputFormats in StorageHandlers
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-5260
> URL: https://issues.apache.org/jira/browse/HIVE-5260
> Project: Hive
> Issue Type: Sub-task
> Components: HBase Handler, HCatalog
> Affects Versions: 0.12.0
> Reporter: Sushanth Sowmyan
> Assignee: Viraj Bhat
> Fix For: 0.12.0
>
>
> This is a task being created to address the hive-side of HIVE-4331.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
