[ https://issues.apache.org/jira/browse/HIVE-4896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13759645#comment-13759645 ]
Sushanth Sowmyan commented on HIVE-4896: ---------------------------------------- All tests pass when I run them, so I'm okay to proceed with committing. Also, I've gone through 4896.add_deprecation and there are a few minor issues with it: * Some whitespace errors (trailing whitespace in the patch) * Some copy-pasted deprecated messages are incorrect: * hcatalog/core/src/test/java/org/apache/hcatalog/data/schema/TestHCatSchemaUtils.java : @deprecated message points to org.apache.hive.hcatalog.data.schema.TestHCatSchema * hcatalog/core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatDynamicPartitioned.java : @deprecated message points to org.apache.hive.hcatalog.mapreduce.TestHCatExternalDynamicPartitioned * org.apache.hive.hcatalog.messaging.json.JSONAddPartitionMessage : @deprecated message points to org.apache.hive.hcatalog.messaging.jms.MessagingUtils They are minor enough that I can correct these in the commit though. Otherwise, I'm +1 on these patches. > create binary backwards compatibility layer hcatalog 0.12 and 0.11 > ------------------------------------------------------------------ > > Key: HIVE-4896 > URL: https://issues.apache.org/jira/browse/HIVE-4896 > Project: Hive > Issue Type: Sub-task > Components: HCatalog > Affects Versions: 0.12.0 > Reporter: Eugene Koifman > Assignee: Eugene Koifman > Fix For: 0.12.0 > > Attachments: 4896.add_deprecation, 4896.fix_shim_layer, > 4896.remove_Exim_add_011_src_test, HIVE-4896.patch > > Original Estimate: 72h > Remaining Estimate: 72h > > 1. create a 011 dir in each HCat submodule to hold these classes > 2. update build to place these classes into jars > 3. figure out how to test this > The goal is for users who were using public API (e.g. HCatLoader) in their > programs to be able to upgrade to hive 0.12 and have their programs still > work without change. > The compatibility layer will have a sunset clause to be removed in 2 releases. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira