Hi Yin, I was able to apply the patch to 11 w/out problems. Thanks.
On Wed, Sep 4, 2013 at 12:41 PM, Yin Huai <huaiyin....@gmail.com> wrote: > Hi Eric, > > Can you try > https://issues.apache.org/jira/secure/attachment/12601446/HIVE-5149-branch-0.11.patch? > > Thanks, > > Yin > > > On Wed, Sep 4, 2013 at 3:14 PM, Yin Huai <huaiyin....@gmail.com> wrote: > >> Sure. Let me take a look at 0.11 branch. >> >> >> On Wed, Sep 4, 2013 at 2:53 PM, Eric Chu <e...@rocketfuel.com> wrote: >> >>> Hi Yin Huai, >>> >>> This patch doesn't apply cleanly in Hive 11. For example, >>> ReduceSinkDeDuplication.java is in >>> ql/src/java/org/apache/hadoop/hive/ql/optimizer/ in Hive 11 while the >>> patch >>> assumes the file is in >>> ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/. It seems >>> like >>> there are other changes on this and related files between Hive 11 and >>> this >>> patch. >>> >>> Could you back port this to 11? The bug breaks correctness in 11, and >>> most >>> users aren't ready to move to Hive. >>> >>> Thanks, >>> >>> Eric >>> >>> >>> On Wed, Sep 4, 2013 at 10:45 AM, Hudson (JIRA) <j...@apache.org> wrote: >>> >>> > >>> > [ >>> > >>> https://issues.apache.org/jira/browse/HIVE-5149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13758030#comment-13758030 >>> ] >>> > >>> > Hudson commented on HIVE-5149: >>> > ------------------------------ >>> > >>> > SUCCESS: Integrated in Hive-trunk-h0.21 #2309 (See [ >>> > https://builds.apache.org/job/Hive-trunk-h0.21/2309/]) >>> > HIVE-5149 : ReduceSinkDeDuplication can pick the wrong partitioning >>> > columns (Yin Huai via Ashutosh Chauhan) (hashutosh: >>> > >>> http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1519805) >>> > * >>> > >>> /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/ReduceSinkDeDuplication.java >>> > * /hive/trunk/ql/src/test/results/clientpositive/groupby2.q.out >>> > * >>> /hive/trunk/ql/src/test/results/clientpositive/groupby2_map_skew.q.out >>> > * /hive/trunk/ql/src/test/results/clientpositive/groupby_cube1.q.out >>> > * /hive/trunk/ql/src/test/results/clientpositive/groupby_rollup1.q.out >>> > * >>> > >>> /hive/trunk/ql/src/test/results/clientpositive/reduce_deduplicate_extended.q.out >>> > >>> > >>> > > ReduceSinkDeDuplication can pick the wrong partitioning columns >>> > > --------------------------------------------------------------- >>> > > >>> > > Key: HIVE-5149 >>> > > URL: https://issues.apache.org/jira/browse/HIVE-5149 >>> > > Project: Hive >>> > > Issue Type: Bug >>> > > Components: Query Processor >>> > > Affects Versions: 0.11.0, 0.12.0 >>> > > Reporter: Yin Huai >>> > > Assignee: Yin Huai >>> > > Priority: Blocker >>> > > Fix For: 0.12.0 >>> > > >>> > > Attachments: HIVE-5149.1.patch, HIVE-5149.2.patch, >>> > HIVE-5149.3.patch >>> > > >>> > > >>> > > >>> > >>> https://mail-archives.apache.org/mod_mbox/hive-user/201308.mbox/%3CCAG6Lhyex5XPwszpihKqkPRpzri2k=m4qgc+cpar5yvr8sjt...@mail.gmail.com%3E >>> > >>> > -- >>> > This message is automatically generated by JIRA. >>> > If you think it was sent incorrectly, please contact your JIRA >>> > administrators >>> > For more information on JIRA, see: >>> http://www.atlassian.com/software/jira >>> > >>> >> >> >
