[ 
https://issues.apache.org/jira/browse/HIVE-4844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753094#comment-13753094
 ] 

Jason Dere commented on HIVE-4844:
----------------------------------

Hi Xuefu, sorry about. I did add precision/scale in a few places, let's take a 
look:

1. JDBC: The precision/scale is also used for returning varchar length, so 
these changes are necessary.
2. BaseTypeParams/TypeQualifiers/TTypeQualifiers: These are objects used to 
hold type qualifier information, and I did add precision/scale fields/setters 
to these objects. If you'd like them removed I can remove any mention of 
precision/scale in these objects.
3. TCLIService.thrift: Add constant string values to represent precision/scale 
fields. I can also remove those constant definitions if you like.

Let me know if you want me to remove mention of precision/scale from (2) and 
(3).
                
> Add char/varchar data types
> ---------------------------
>
>                 Key: HIVE-4844
>                 URL: https://issues.apache.org/jira/browse/HIVE-4844
>             Project: Hive
>          Issue Type: New Feature
>          Components: Types
>            Reporter: Jason Dere
>            Assignee: Jason Dere
>         Attachments: HIVE-4844.1.patch.hack, HIVE-4844.2.patch, 
> HIVE-4844.3.patch, HIVE-4844.4.patch, HIVE-4844.5.patch, HIVE-4844.6.patch, 
> HIVE-4844.7.patch, HIVE-4844.8.patch, HIVE-4844.9.patch, screenshot.png
>
>
> Add new char/varchar data types which have support for more SQL-compliant 
> behavior, such as SQL string comparison semantics, max length, etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to