[
https://issues.apache.org/jira/browse/HIVE-4617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747014#comment-13747014
]
Phabricator commented on HIVE-4617:
-----------------------------------
thejas has commented on the revision "HIVE-4617 [jira] ExecuteStatementAsync
call to run a query in non-blocking mode".
INLINE COMMENTS
service/if/TCLIService.thrift:603 I think it is better to make use of a
thrift optional parameter here, instead of creating a new function. Creating a
new thrift function every time we add parameters would be bad.
service/if/TCLIService.thrift:623 This is also not needed, the contents are
same as TExecuteStatementResp
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java:68 A
sessionstate does not have to be stored here.
It should just use SessionState.get() and use that to set sessionstate in new
thread
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java:122
add a SessionState ss = SessionState.get() and set it in the new thread.
service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java:183
this call would go away when sessionstate is not stored in SQLOperation
service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java:59
since the state object in operation is going to be accessed by multiple
threads, i think it is safer to make the instance a volatile instance.
service/src/test/org/apache/hive/service/cli/CLIServiceTest.java:140 can you
add a max wait for this ? If something goes wrong the test will run for ever.
REVISION DETAIL
https://reviews.facebook.net/D12417
To: JIRA, vaibhavgumashta
Cc: thejas
> ExecuteStatementAsync call to run a query in non-blocking mode
> --------------------------------------------------------------
>
> Key: HIVE-4617
> URL: https://issues.apache.org/jira/browse/HIVE-4617
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
> Affects Versions: 0.11.0
> Reporter: Jaideep Dhok
> Assignee: Vaibhav Gumashta
> Attachments: HIVE-4617.D12417.1.patch
>
>
> Provide a way to run a queries asynchronously. Current executeStatement call
> blocks until the query run is complete.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
