[ https://issues.apache.org/jira/browse/HIVE-5018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13740927#comment-13740927 ]
Brock Noland commented on HIVE-5018: ------------------------------------ The build failed. In this instance you information directly above that: [checkstyle] /data/hive-ptest/working/apache-svn-trunk-source/hcatalog/storage-handlers/hbase/src/java/org/apache/hcatalog/hbase/snapshot/ZKUtil.java:417: if child at indentation level 48 not at correct indentation, 12 Note that hcat uses 4 spaces for tab while hive uses 2. > Avoiding object instantiation in loops (issue 6) > ------------------------------------------------ > > Key: HIVE-5018 > URL: https://issues.apache.org/jira/browse/HIVE-5018 > Project: Hive > Issue Type: Sub-task > Reporter: Benjamin Jakobus > Assignee: Benjamin Jakobus > Priority: Minor > Fix For: 0.12.0 > > Attachments: HIVE-5018.1.patch.txt > > > Object instantiation inside loops is very expensive. Where possible, object > references should be created outside the loop so that they can be reused. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira