[ 
https://issues.apache.org/jira/browse/HIVE-4778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Phabricator updated HIVE-4778:
------------------------------

    Attachment: HIVE-4778.D12207.1.patch

azrael requested code review of "HIVE-4778 [jira] hive.server2.authentication 
CUSTOM not working".

Reviewers: JIRA

TEST PLAN
  unit test and manual test

REVISION DETAIL
  https://reviews.facebook.net/D12207

AFFECTED FILES
  build-common.xml
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
  conf/hive-default.xml.template
  hbase-handler/src/test/templates/TestHBaseCliDriver.vm
  ql/src/gen/protobuf/gen-java/org/apache/hadoop/hive/ql/io/orc/OrcProto.java
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java
  ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistory.java
  ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryImpl.java
  ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryProxyHandler.java
  ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryUtil.java
  ql/src/java/org/apache/hadoop/hive/ql/history/HiveHistoryViewer.java
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/IntegerReader.java
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/IntegerWriter.java
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java.orig
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/RunLengthIntegerReader.java
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/RunLengthIntegerReaderV2.java
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/RunLengthIntegerWriter.java
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/RunLengthIntegerWriterV2.java
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/SerializationUtils.java
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java
  
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/StorageBasedAuthorizationProvider.java
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFDecode.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBase64.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFHex.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFUnbase64.java
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFUnhex.java
  ql/src/protobuf/org/apache/hadoop/hive/ql/io/orc/orc_proto.proto
  ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java
  ql/src/test/org/apache/hadoop/hive/ql/history/TestHiveHistory.java
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestBitPack.java
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestIntegerCompressionReader.java
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestNewIntegerEncoding.java
  ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcNullOptimization.java
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDecode.java
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFEncode.java
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFBase64.java
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFHex.java
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFUnbase64.java
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFUnhex.java
  ql/src/test/queries/clientpositive/ba_table_udfs.q
  ql/src/test/queries/clientpositive/nonblock_op_deduplicate.q
  ql/src/test/queries/clientpositive/partition_date.q
  ql/src/test/queries/clientpositive/partition_date2.q
  ql/src/test/queries/clientpositive/ppd_vc.q
  ql/src/test/queries/clientpositive/schemeAuthority2.q
  ql/src/test/queries/clientpositive/udf_sentences.q
  ql/src/test/resources/orc-file-dump-dictionary-threshold.out
  ql/src/test/resources/orc-file-dump.out
  ql/src/test/results/clientnegative/fs_default_name1.q.out
  ql/src/test/results/clientnegative/fs_default_name2.q.out
  ql/src/test/results/clientpositive/auto_join14.q.out
  ql/src/test/results/clientpositive/ba_table_udfs.q.out
  ql/src/test/results/clientpositive/input12.q.out
  ql/src/test/results/clientpositive/join14.q.out
  ql/src/test/results/clientpositive/nonblock_op_deduplicate.q.out
  ql/src/test/results/clientpositive/partition_date.q.out
  ql/src/test/results/clientpositive/partition_date2.q.out
  ql/src/test/results/clientpositive/ppd_vc.q.out
  ql/src/test/results/clientpositive/schemeAuthority2.q.out
  ql/src/test/results/clientpositive/show_functions.q.out
  ql/src/test/results/clientpositive/udf_hex.q.out
  ql/src/test/results/clientpositive/udf_sentences.q.out
  ql/src/test/results/clientpositive/udf_unhex.q.out
  ql/src/test/results/clientpositive/union_remove_19.q.out
  ql/src/test/templates/TestCliDriver.vm
  
service/src/java/org/apache/hive/service/auth/CustomAuthenticationProviderImpl.java
  service/src/test/org/apache/hive/service/auth/TestCustomAuthentication.java
  shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java
  shims/src/0.20S/java/org/apache/hadoop/hive/shims/Hadoop20SShims.java
  shims/src/0.23/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java
  shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java

MANAGE HERALD RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/29163/

To: JIRA, azrael

                
> hive.server2.authentication CUSTOM not working
> ----------------------------------------------
>
>                 Key: HIVE-4778
>                 URL: https://issues.apache.org/jira/browse/HIVE-4778
>             Project: Hive
>          Issue Type: Bug
>          Components: Authentication
>    Affects Versions: 0.11.0
>         Environment: CentOS release 6.2 x86_64
> java version "1.6.0_31"
> Java(TM) SE Runtime Environment (build 1.6.0_31-b04)
> Java HotSpot(TM) 64-Bit Server VM (build 20.6-b01, mixed mode)
>            Reporter: Zdenek Ott
>            Assignee: Azrael Park
>         Attachments: HIVE-4778.D12207.1.patch
>
>
> I have created my own class PamAuthenticationProvider that implements 
> PasswdAuthenticationProvider interface. I have puted jar into hive lib 
> directory and have configured hive-site.xml in following way:
> <property>
>   <name>hive.server2.authentication</name>
>   <value>CUSTOM</value>
> </property>
> <property>
>   <name>hive.server2.custom.authentication.class</name>
>   <value>com.avast.ff.hive.PamAuthenticationProvider</value>
> </property>
> I use SQuireL and jdbc drivers to connect to hive. During authentication Hive 
> throws following exception:
> java.lang.RuntimeException: java.lang.NoSuchMethodException: 
> org.apache.hive.service.auth.PasswdAuthenticationProvider.<init>()
>         at 
> org.apache.hadoop.util.ReflectionUtils.newInstance(ReflectionUtils.java:128)
>         at 
> org.apache.hive.service.auth.CustomAuthenticationProviderImpl.<init>(CustomAuthenticationProviderImpl.java:20)
>         at 
> org.apache.hive.service.auth.AuthenticationProviderFactory.getAuthenticationProvider(AuthenticationProviderFactory.java:57)
>         at 
> org.apache.hive.service.auth.PlainSaslHelper$PlainServerCallbackHandler.handle(PlainSaslHelper.java:61)
>         at 
> org.apache.hive.service.auth.PlainSaslServer.evaluateResponse(PlainSaslServer.java:127)
>         at 
> org.apache.thrift.transport.TSaslTransport$SaslParticipant.evaluateChallengeOrResponse(TSaslTransport.java:509)
>         at 
> org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:264)
>         at 
> org.apache.thrift.transport.TSaslServerTransport.open(TSaslServerTransport.java:41)
>         at 
> org.apache.thrift.transport.TSaslServerTransport$Factory.getTransport(TSaslServerTransport.java:216)
>         at 
> org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:189)
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
>         at java.lang.Thread.run(Thread.java:662)
> Caused by: java.lang.NoSuchMethodException: 
> org.apache.hive.service.auth.PasswdAuthenticationProvider.<init>()
>         at java.lang.Class.getConstructor0(Class.java:2706)
>         at java.lang.Class.getDeclaredConstructor(Class.java:1985)
>         at 
> org.apache.hadoop.util.ReflectionUtils.newInstance(ReflectionUtils.java:122)
>         ... 12 more
> I have done small patch for 
> org.apache.hive.service.auth.CustomAuthenticationProviderImpl , that have 
> solved my problem, but I'm not sure if it's the best solution. Here is the 
> patch:
> --- CustomAuthenticationProviderImpl.java       2013-06-20 14:55:22.473995184 
> +0200
> +++ CustomAuthenticationProviderImpl.java.new   2013-06-20 14:57:36.549012966 
> +0200
> @@ -33,7 +33,7 @@
>      HiveConf conf = new HiveConf();
>      this.customHandlerClass = (Class<? extends PasswdAuthenticationProvider>)
>          conf.getClass(
> -            
> HiveConf.ConfVars.HIVE_SERVER2_CUSTOM_AUTHENTICATION_CLASS.name(),
> +            
> HiveConf.ConfVars.HIVE_SERVER2_CUSTOM_AUTHENTICATION_CLASS.varname,
>              PasswdAuthenticationProvider.class);
>      this.customProvider =
>          ReflectionUtils.newInstance(this.customHandlerClass, conf);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to