[
https://issues.apache.org/jira/browse/HIVE-5003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737198#comment-13737198
]
Edward Capriolo commented on HIVE-5003:
---------------------------------------
I think we are repeating a semi-disturbing trend of writing a lot of code we
have little direct coverage for. For example take a method like:
{code}
private static Path getDefaultDestDir(Configuration conf) throws
LoginException, IOException {
{code}
or
{code}
private static String getExecJarPathLocal () {
{code}
I think we should have direct junit style tests around these methods. The code
clean (for its development state) and well documented. But I think we have the
chance to "do it better".
Right now, for our current code, and this code. We are totally reliant on our
end-to-end system to validate every minor change. If we have smaller unit tests
on things like this we can have more coverage and enhance our ability to make
changes to the project without having as many worries around side effects that
will not manifest until final end to end tests.
I think we should draw a line in the sand and here and attempt to write unit
tests and design code in a testable way. Not just write it and worry about unit
tests later. What do you think?
> Localize hive exec jar for tez
> ------------------------------
>
> Key: HIVE-5003
> URL: https://issues.apache.org/jira/browse/HIVE-5003
> Project: Hive
> Issue Type: Bug
> Reporter: Gunther Hagleitner
> Assignee: Vikram Dixit K
> Fix For: tez-branch
>
> Attachments: HIVE-5003.1.patch.txt, HIVE-5003.2.patch.txt,
> HIVE-5003.3.patch.txt, HIVE-5003.4.patch.txt, HiveLocalizationDesign.txt
>
>
> Tez doesn't expose a distributed cache. JARs are localized via yarn APIs and
> added to vertices and the dag itself as needed. For hive we need to localize
> the hive-exec.jar.
> NO PRECOMMIT TESTS (this is wip for the tez branch)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
