[
https://issues.apache.org/jira/browse/HIVE-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13735566#comment-13735566
]
Mark Grover commented on HIVE-5046:
-----------------------------------
Eugene, thanks for posting. I don't think so. The intent of the snippet you
mentioned is to do something with the variable ({{HIVE_IN_PATH}}) if it is
defined. That something is to make use to {{HIVE_IN_PATH}} to popualate
{{HIVE_DIR}}.
On the other hand, the intent of the snippet 12 lines later (that this JIRA
addresses) is to do something if the variable is not defined. That something is
to set HIVE_HOME to some default value. This snippet however, checks if the
variable is not null instead of checking if the variable is null.
> Hcatalog's bin/hcat script doesn't respect HIVE_HOME
> ----------------------------------------------------
>
> Key: HIVE-5046
> URL: https://issues.apache.org/jira/browse/HIVE-5046
> Project: Hive
> Issue Type: Bug
> Components: HCatalog
> Affects Versions: 0.11.0
> Reporter: Mark Grover
> Assignee: Mark Grover
> Attachments: HIVE-5046.1.patch
>
>
> https://github.com/apache/hive/blob/trunk/hcatalog/bin/hcat#L81
> The quoted snippet (see below) intends to set HIVE_HOME if it's not set (i.e.
> HIVE_HOME is currently null).
> {code}
> if [ -n ${HIVE_HOME} ]; then
> {code}
> However, {{-n}} checks if the variable is _not_ null. So, the above code ends
> up setting HIVE_HOME to the default value if it is actually set already,
> overriding the set value. This condition needs to be negated.
> Moreover, {{-n}} checks requires the string being tested to be enclosed in
> quotes.
> Reference:
> http://tldp.org/LDP/abs/html/comparison-ops.html
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
