----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11046/#review24708 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java <https://reviews.apache.org/r/11046/#comment48819> Yes, as seen in the exception in the description, the new instance tries to make a connection to metastore. metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java <https://reviews.apache.org/r/11046/#comment48866> I think prevention is better than cure. This is not an expensive method, failure will result in some time spent sleeping before retrying. I will move the base.reconnect() here so that relogin happens before it is called. metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java <https://reviews.apache.org/r/11046/#comment48868> will call it reloginExpiringKeytabUser shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java <https://reviews.apache.org/r/11046/#comment48876> This is the message other similar functions report. I can change the rest of them in a separate patch. - Thejas Nair On Aug. 3, 2013, 3 a.m., Thejas Nair wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11046/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2013, 3 a.m.) > > > Review request for hive. > > > Bugs: HIVE-4233 > https://issues.apache.org/jira/browse/HIVE-4233 > > > Repository: hive-git > > > Description > ------- > > HIVE-4233- The TGT gotten from class 'CLIService' should be renewed on time > > > Diffs > ----- > > > metastore/src/java/org/apache/hadoop/hive/metastore/RetryingMetaStoreClient.java > 76b1989 > shims/src/0.20/java/org/apache/hadoop/hive/shims/Hadoop20Shims.java c9baa7f > > shims/src/common-secure/java/org/apache/hadoop/hive/shims/HadoopShimsSecure.java > 9edcafd > shims/src/common/java/org/apache/hadoop/hive/shims/HadoopShims.java b0f5077 > > Diff: https://reviews.apache.org/r/11046/diff/ > > > Testing > ------- > > manually tested on secure hadoop cluster. > > > Thanks, > > Thejas Nair > >
