[ https://issues.apache.org/jira/browse/HIVE-4954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13723513#comment-13723513 ]
Hive QA commented on HIVE-4954: ------------------------------- {color:red}Overall{color}: -1 no tests executed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12594832/HIVE-4954.1.patch.txt Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/231/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/231/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Tests failed with: NonZeroExitCodeException: Command 'bash /data/hive-ptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ [[ -n '' ]] + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m -Dhttp.proxyHost=localhost -Dhttp.proxyPort=3128' + cd /data/hive-ptest/working/ + tee /data/hive-ptest/logs/PreCommit-HIVE-Build-231/source-prep.txt + mkdir -p maven ivy + [[ svn = \s\v\n ]] + [[ -n '' ]] + [[ -d apache-svn-trunk-source ]] + [[ ! -d apache-svn-trunk-source/.svn ]] + [[ ! -d apache-svn-trunk-source ]] + cd apache-svn-trunk-source + svn revert -R . Reverted 'ql/src/test/results/clientpositive/join33.q.out' Reverted 'ql/src/test/results/clientpositive/auto_sortmerge_join_4.q.out' Reverted 'ql/src/test/results/clientpositive/bucketcontext_7.q.out' Reverted 'ql/src/test/results/clientpositive/auto_sortmerge_join_11.q.out' Reverted 'ql/src/test/results/clientpositive/bucketcontext_2.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin7.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin11.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin_negative.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin2.q.out' Reverted 'ql/src/test/results/clientpositive/auto_sortmerge_join_1.q.out' Reverted 'ql/src/test/results/clientpositive/bucketcontext_4.q.out' Reverted 'ql/src/test/results/clientpositive/sort_merge_join_desc_7.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin9.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin13.q.out' Reverted 'ql/src/test/results/clientpositive/union22.q.out' Reverted 'ql/src/test/results/clientpositive/join32.q.out' Reverted 'ql/src/test/results/clientpositive/auto_sortmerge_join_8.q.out' Reverted 'ql/src/test/results/clientpositive/auto_sortmerge_join_3.q.out' Reverted 'ql/src/test/results/clientpositive/bucketcontext_1.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin10.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin1.q.out' Reverted 'ql/src/test/results/clientpositive/bucketcontext_8.q.out' Reverted 'ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out' Reverted 'ql/src/test/results/clientpositive/bucketcontext_3.q.out' Reverted 'ql/src/test/results/clientpositive/sort_merge_join_desc_6.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin8.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin12.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin3.q.out' Reverted 'ql/src/test/results/clientpositive/join32_lessSize.q.out' Reverted 'ql/src/test/results/clientpositive/auto_sortmerge_join_7.q.out' Reverted 'ql/src/test/results/clientpositive/bucketmapjoin_negative2.q.out' Reverted 'ql/src/test/results/clientpositive/auto_sortmerge_join_2.q.out' Reverted 'ql/src/test/results/clientpositive/stats11.q.out' Reverted 'ql/src/java/org/apache/hadoop/hive/ql/plan/FetchWork.java' ++ egrep -v '^X|^Performing status on external' ++ awk '{print $2}' ++ svn status --no-ignore + rm -rf build hcatalog/build hcatalog/core/build hcatalog/storage-handlers/hbase/build hcatalog/server-extensions/build hcatalog/webhcat/svr/build hcatalog/webhcat/java-client/build hcatalog/hcatalog-pig-adapter/build common/src/gen ql/src/test/results/clientpositive/bucketmapjoin2.q.out.orig ql/src/test/results/clientpositive/join32_lessSize.q.out.orig ql/src/test/results/clientpositive/bucketmapjoin1.q.out.orig ql/src/test/results/clientpositive/bucketmapjoin7.q.out.orig ql/src/test/results/clientpositive/union22.q.out.orig ql/src/test/results/clientpositive/auto_sortmerge_join_11.q.out.orig ql/src/test/results/clientpositive/bucketmapjoin3.q.out.orig + svn update Fetching external item into 'hcatalog/src/test/e2e/harness' External at revision 1508328. At revision 1508328. + patchCommandPath=/data/hive-ptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hive-ptest/working/scratch/build.patch + [[ -f /data/hive-ptest/working/scratch/build.patch ]] + chmod +x /data/hive-ptest/working/scratch/smart-apply-patch.sh + /data/hive-ptest/working/scratch/smart-apply-patch.sh /data/hive-ptest/working/scratch/build.patch The patch does not appear to apply with p0 to p2 + exit 1 ' {noformat} This message is automatically generated. > PTFTranslator hardcodes ranking functions > ----------------------------------------- > > Key: HIVE-4954 > URL: https://issues.apache.org/jira/browse/HIVE-4954 > Project: Hive > Issue Type: Improvement > Reporter: Edward Capriolo > Assignee: Edward Capriolo > Attachments: HIVE-4954.1.patch.txt > > > protected static final ArrayList<String> RANKING_FUNCS = new > ArrayList<String>(); > static { > RANKING_FUNCS.add("rank"); > RANKING_FUNCS.add("dense_rank"); > RANKING_FUNCS.add("percent_rank"); > RANKING_FUNCS.add("cume_dist"); > }; > Move this logic to annotations -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira