[ 
https://issues.apache.org/jira/browse/HIVE-4941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13721967#comment-13721967
 ] 

Brock Noland commented on HIVE-4941:
------------------------------------

OK, the first item is that PTest2 wasn't reporting on all the tests that it 
ran. This was fixed in HIVE-4892. Now as it did 
[https://issues.apache.org/jira/browse/HIVE-4299?focusedCommentId=13721929&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13721929]
 and 
[here|https://issues.apache.org/jira/browse/HIVE-3926?focusedCommentId=13721861&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13721861]
 PTest2 should be reporting ~2729.

I counted the number of tests ran by ant test and ptest2 and I got the 
following This is using grep '<testcase':

{noformat}
$ wc -l ant.txt ptest.txt 
  2747 ant.txt
  2729 ptest.txt
{noformat}

I found some interesting items.

1) Ptest2 doesn't exclude skipped tests from reporting
2) PTest2 tracks "include" properties specified in the build.xml files 
separately (only impacts minimr and testhbasedriver) and they are slightly out 
of date. Short term I can fix this and create instructions on how to update 
PTest2 when adding a minimr test. Medium term we should just parse these 
properties out of the build.xml.
3) Some tests don't start with Test and therefore PTest2 misses them
4) In PTest2 we list out the directories we expect to find unit tests. One 
directory is missing. Short term fix is to list it and medium term fix is just 
to look in all directories.
                
> PTest2 Investigate Ignores
> --------------------------
>
>                 Key: HIVE-4941
>                 URL: https://issues.apache.org/jira/browse/HIVE-4941
>             Project: Hive
>          Issue Type: Task
>            Reporter: Brock Noland
>            Assignee: Brock Noland
>            Priority: Minor
>
> Currently we excluding the following tests:
> unitTests.exclude = TestHiveMetaStore TestSerDe TestBeeLineDriver 
> TestHiveServer2Concurrency TestJdbcDriver2 TestHiveServer2Concurrency 
> TestBeeLineDriver
> some of them we got from the build files but I am not sure about 
> TestJdbcDriver2 for example. We should investigate why these are excluded.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to